From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O8wXK-0006cA-5X for qemu-devel@nongnu.org; Mon, 03 May 2010 10:22:18 -0400 Received: from [140.186.70.92] (port=39043 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O8wXB-0006az-5N for qemu-devel@nongnu.org; Mon, 03 May 2010 10:22:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O8wX9-0005x0-Hh for qemu-devel@nongnu.org; Mon, 03 May 2010 10:22:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34700) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O8wX9-0005wr-7G for qemu-devel@nongnu.org; Mon, 03 May 2010 10:22:07 -0400 Message-ID: <4BDEDBF4.1000702@redhat.com> Date: Mon, 03 May 2010 16:21:40 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: Improve error reporting References: <1272837025-4975-1-git-send-email-ozaki.ryota@gmail.com> In-Reply-To: <1272837025-4975-1-git-send-email-ozaki.ryota@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryota Ozaki Cc: qemu-devel@nongnu.org Am 02.05.2010 23:50, schrieb Ryota Ozaki: > - use err(3) instead of errx(3) if errno is available > to report why failed > - let fail prior to daemon(3) if opening a nbd file > is likely to fail after daemonizing to avoid silent > failure exit > - add missing 'ret = 1' when unix_socket_outgoing failed > > Signed-off-by: Ryota Ozaki Thanks, applied to the block branch. Kevin