From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O8z02-00051e-8i
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:00:06 -0400
Received: from [140.186.70.92] (port=59783 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O8z00-00051W-0I
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:00:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O8yzx-0007Jp-RS
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:00:03 -0400
Received: from mail-iw0-f184.google.com ([209.85.223.184]:51490)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O8yzx-0007IP-OZ
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:00:01 -0400
Received: by iwn14 with SMTP id 14so3495385iwn.22
	for <qemu-devel@nongnu.org>; Mon, 03 May 2010 10:00:00 -0700 (PDT)
Message-ID: <4BDF010B.6090007@codemonkey.ws>
Date: Mon, 03 May 2010 11:59:55 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add()
	to QObject"
References: <m3vdbexg5o.fsf@blackfin.pond.sub.org>	<20100426152137.34ee9fbe@redhat.com>
	<m3mxwhz629.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3mxwhz629.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 05/03/2010 04:29 AM, Markus Armbruster wrote:
> Luiz Capitulino<lcapitulino@redhat.com>  writes:
>
>    
>> On Mon, 26 Apr 2010 19:44:19 +0200
>> Markus Armbruster<armbru@redhat.com>  wrote:
>>
>>      
>>> We don't want pci_add in QMP.  Use device_add instead.
>>>
>>> This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949.
>>>
>>> Conflicts:
>>>
>>> 	hw/pci-hotplug.c
>>> 	sysemu.h
>>>
>>> Signed-off-by: Markus Armbruster<armbru@redhat.com>
>>>        
>>   The patch looks ok and I'm assuming that device_add can do everything
>> pci_add does, right?
>>      
> Not quite.
>
> pci_add comes in several flavors:
>
> * nic: Hot plug a PCI NIC.  device_add is more general.
>
> * storage: Hot plug a PCI disk controller, and a drive connected to it.
>
>    The controller is either virtio-blk-pci (if=virtio) or lsi53c895a
>    (if=scsi).  With the latter, the drive is optional.  Use drive_add to
>    hotplug additional SCSI drives.  Except drive_add is not available in
>    QMP.
>
>    device_add is more general for controllers and the guest part of
>    drives.  I'm working on a more general alternative for the host part
>    of drives.
>
> Why am I proposing to remove pci_add from QMP before its replacement is
> ready?  I want it out sooner rather than later, because it isn't fully
> functional (errors and drive_add are missing), and we do not plan to
> complete the job.  In other words, it's not really usable over QMP now,
> and it's not what we want for QMP anyway.  Since we don't want it to be
> used over QMP, we should take it out, not leave it around as a trap for
> the uninitiated.
>
> Anyway, I'll respin with a more verbose commit message, and I'll throw
> in the buddy patch Revert "monitor: Convert do_pci_device_hot_remove()
> to QObject".
>    

Does libvirt not use pci_add with QMP?

Regards,

Anthony Liguori

>
>