From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O8z21-0005ap-E5
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:02:09 -0400
Received: from [140.186.70.92] (port=60236 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O8z1z-0005aF-S6
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:02:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O8z1y-0007g5-B8
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:02:07 -0400
Received: from mail-iw0-f184.google.com ([209.85.223.184]:38188)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O8z1y-0007g0-84
	for qemu-devel@nongnu.org; Mon, 03 May 2010 13:02:06 -0400
Received: by iwn14 with SMTP id 14so3498323iwn.22
	for <qemu-devel@nongnu.org>; Mon, 03 May 2010 10:02:05 -0700 (PDT)
Message-ID: <4BDF0189.7030404@codemonkey.ws>
Date: Mon, 03 May 2010 12:02:01 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Fix qemu mouse Set_Protocol behavior
References: <20100502023851.GA16268@morn.localdomain>
In-Reply-To: <20100502023851.GA16268@morn.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On 05/01/2010 09:38 PM, Kevin O'Connor wrote:
> The QEMU USB mouse claims to support the "boot" protocol
> (bInterfaceSubClass is 1).  However, the mouse rejects the
> Set_Protocol command.
>
> The qemu mouse does support the "boot" protocol specification, so a
> simple fix is to just enable the Set_Portocol request.
>
> -Kevin
>    

Could you included a Signed-of-by: and resubmit both patches?

Thanks,

Anthony Liguori

> --- a/hw/usb-hid.c
> +++ b/hw/usb-hid.c
> @@ -790,13 +790,13 @@ static int usb_hid_handle_control(USBDevice *dev, int request, int value,
>               goto fail;
>           break;
>       case GET_PROTOCOL:
> -        if (s->kind != USB_KEYBOARD)
> +        if (s->kind != USB_KEYBOARD&&  s->kind != USB_MOUSE)
>               goto fail;
>           ret = 1;
>           data[0] = s->protocol;
>           break;
>       case SET_PROTOCOL:
> -        if (s->kind != USB_KEYBOARD)
> +        if (s->kind != USB_KEYBOARD&&  s->kind != USB_MOUSE)
>               goto fail;
>           ret = 0;
>           s->protocol = value;
>
>
>
>