From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O90J7-00049U-4I
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:23:53 -0400
Received: from [140.186.70.92] (port=46507 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O90If-0003ND-4A
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:23:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O903f-0000oh-1H
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:07:56 -0400
Received: from mail-qy0-f188.google.com ([209.85.221.188]:61276)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O903e-0000bN-Uh
	for qemu-devel@nongnu.org; Mon, 03 May 2010 14:07:54 -0400
Received: by qyk26 with SMTP id 26so4216335qyk.19
	for <qemu-devel@nongnu.org>; Mon, 03 May 2010 11:06:31 -0700 (PDT)
Message-ID: <4BDF1095.5050704@codemonkey.ws>
Date: Mon, 03 May 2010 13:06:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix whitespace bogon in some versions of make
References: <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
In-Reply-To: <1272318743-17113-1-git-send-email-froydnj@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 04/26/2010 04:52 PM, Nathan Froyd wrote:
> With three different make binaries I have available, configuring a
> pristine QEMU tree and attempting to make gives the cryptic:
>
> Makefile:27: *** missing separator.  Stop.
>
> This patch fixes it (presumably because it makes the output of
> `set-vpath' be an empty string, rather than a bit of whitespace), but I
> don't understand why this hasn't been a problem for other folks before.
>
> Signed-off-by: Nathan Froyd<froydnj@codesourcery.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   rules.mak |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5941b73..7e10432 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -40,7 +40,7 @@ cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
>                 >/dev/null 2>&1&&  echo OK), $2, $3)
>
>   VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
> -set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES), $(eval vpath $(PATTERN) $1)))
> +set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
>
>   # Generate timestamp files for .h include files
>
>