From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9E4p-0001BD-L1 for qemu-devel@nongnu.org; Tue, 04 May 2010 05:06:03 -0400 Received: from [140.186.70.92] (port=56141 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9E4o-00019C-6X for qemu-devel@nongnu.org; Tue, 04 May 2010 05:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9E4m-00031O-Ey for qemu-devel@nongnu.org; Tue, 04 May 2010 05:06:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63936) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9CZV-0003ZL-Of for qemu-devel@nongnu.org; Tue, 04 May 2010 03:29:38 -0400 Message-ID: <4BDFCCC2.6050900@redhat.com> Date: Tue, 04 May 2010 09:29:06 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting References: <1269796032-9166-1-git-send-email-ozaki.ryota@gmail.com> <1269796032-9166-3-git-send-email-ozaki.ryota@gmail.com> <4BB088E5.30800@redhat.com> <4BDF014E.10709@codemonkey.ws> In-Reply-To: <4BDF014E.10709@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Ryota Ozaki , qemu-devel@nongnu.org Am 03.05.2010 19:01, schrieb Anthony Liguori: > On 03/29/2010 06:03 AM, Kevin Wolf wrote: >> Am 28.03.2010 19:07, schrieb Ryota Ozaki: >> >>> - use err(3) instead of errx(3) if errno is available >>> to report why failed >>> - let fail prior to daemon(3) if opening a nbd file >>> is likely to fail after daemonizing to avoid silent >>> failure exit >>> - add missing 'ret = 1' when unix_socket_outgoing failed >>> >>> Signed-off-by: Ryota Ozaki >>> >> Acked-by: Kevin Wolf >> > > Are you going to pull this into the block branch? There was a v2 of this patch yesterday, which I did apply to the block branch. Kevin