From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9DGJ-0002T8-NK for qemu-devel@nongnu.org; Tue, 04 May 2010 04:13:51 -0400 Received: from [140.186.70.92] (port=37963 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9DGI-0002Sw-Dk for qemu-devel@nongnu.org; Tue, 04 May 2010 04:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9DGG-0002ES-9j for qemu-devel@nongnu.org; Tue, 04 May 2010 04:13:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17594) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9DGF-0002EN-Tq for qemu-devel@nongnu.org; Tue, 04 May 2010 04:13:48 -0400 Message-ID: <4BDFD72F.20502@redhat.com> Date: Tue, 04 May 2010 10:13:35 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1272957442-7832-1-git-send-email-amit.shah@redhat.com> <1272957442-7832-2-git-send-email-amit.shah@redhat.com> <1272957442-7832-3-git-send-email-amit.shah@redhat.com> <1272957442-7832-4-git-send-email-amit.shah@redhat.com> <4BDFD008.3000106@redhat.com> <20100504075623.GA8136@amit-x200.redhat.com> In-Reply-To: <20100504075623.GA8136@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paul Brook , qemu list , Juan Quintela On 05/04/10 09:56, Amit Shah wrote: >> The logic will be pretty much the same for all filehandle-based backends >> on unix. So maybe create some helper functions, so implementing >> $backend_chr_write_unblocked can be done with just three lines of code? > > Yes, that's the next step. Let's push this for now and do that in a > later patch series? Fine with me. cheers, Gerd