From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9Ea9-0003ua-SZ
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:38:25 -0400
Received: from [140.186.70.92] (port=46593 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9Ea6-0003sw-5o
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:38:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O9Ea4-00048Q-H7
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:38:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19704)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1O9Ea4-00047x-50
	for qemu-devel@nongnu.org; Tue, 04 May 2010 05:38:20 -0400
Message-ID: <4BDFEB09.3060309@redhat.com>
Date: Tue, 04 May 2010 12:38:17 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4BD6B27C.4060500@msgid.tls.msk.ru>
In-Reply-To: <4BD6B27C.4060500@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: apparent key mapping error for usb keyboard
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>, KVM list <kvm@vger.kernel.org>

On 04/27/2010 12:46 PM, Michael Tokarev wrote:
> I've a debian bugreport that claims to have a fix
> for apparently wrong keymap for usb keyboard.  I
> noticed this before with ps/2 keyboard too, the
> sympthoms were that e.g windows keys were not
> working in guests, but later on that has been
> fixed.  But with `-usbdevice keyboard', i.e. with
> usb keyboard, it still does not work.  See
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578846
> for details and for the proposed patch which
> fixes the mentioned issue.  Here's the patch itself:
>
> --- a/hw/usb-hid.c
> +++ b/hw/usb-hid.c
> @@ -399,3 +399,3 @@
>      0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
> -    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
>      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>
> I'm not sure if it's right fix however.  Hence I'm
> asking for opinions here.  If it's a right way to go,
> it should probably be applied to -stable too.

I've no idea, but the correct place to ask is qemu-devel (copied).

-- 
error compiling committee.c: too many arguments to function