From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9ZpM-0002T8-BA for qemu-devel@nongnu.org; Wed, 05 May 2010 04:19:32 -0400 Received: from [140.186.70.92] (port=38414 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9ZpJ-0002SG-5P for Qemu-devel@nongnu.org; Wed, 05 May 2010 04:19:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9ZpH-0001ha-Sd for Qemu-devel@nongnu.org; Wed, 05 May 2010 04:19:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24079) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9ZpH-0001gy-LM for Qemu-devel@nongnu.org; Wed, 05 May 2010 04:19:27 -0400 Message-ID: <4BE129F0.8000905@redhat.com> Date: Wed, 05 May 2010 10:18:56 +0200 From: Kevin Wolf MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [Commit 20d97356] Fix OpenBSD build List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Qemu-devel@nongnu.org Hi Blue Swirl, did I miss the patch posted for this commit? I can't find it on the mailing list. I think the BlockDriver declarations should really stay at the end of the source file of each driver. What about using a different way to get rid of the static forward declaration, namely using bdrv_find_format() instead of referencing it directly? If you agree I'll post patches to revert your change and use this solution instead. Kevin