* [Qemu-devel] [Commit 20d97356] Fix OpenBSD build
@ 2010-05-05 8:18 Kevin Wolf
2010-05-06 17:55 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2010-05-05 8:18 UTC (permalink / raw)
To: Blue Swirl; +Cc: Qemu-devel
Hi Blue Swirl,
did I miss the patch posted for this commit? I can't find it on the
mailing list. I think the BlockDriver declarations should really stay at
the end of the source file of each driver.
What about using a different way to get rid of the static forward
declaration, namely using bdrv_find_format() instead of referencing it
directly? If you agree I'll post patches to revert your change and use
this solution instead.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [Commit 20d97356] Fix OpenBSD build
2010-05-05 8:18 [Qemu-devel] [Commit 20d97356] Fix OpenBSD build Kevin Wolf
@ 2010-05-06 17:55 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2010-05-06 17:55 UTC (permalink / raw)
To: Kevin Wolf; +Cc: Qemu-devel
On 5/5/10, Kevin Wolf <kwolf@redhat.com> wrote:
> Hi Blue Swirl,
>
> did I miss the patch posted for this commit? I can't find it on the
> mailing list. I think the BlockDriver declarations should really stay at
> the end of the source file of each driver.
>
> What about using a different way to get rid of the static forward
> declaration, namely using bdrv_find_format() instead of referencing it
> directly? If you agree I'll post patches to revert your change and use
> this solution instead.
Somehow I can't form in my mind the change from your description, but
I'd be fine with that too if it also compiles in OpenBSD.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-06 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-05 8:18 [Qemu-devel] [Commit 20d97356] Fix OpenBSD build Kevin Wolf
2010-05-06 17:55 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).