From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9fac-0004vG-6v for qemu-devel@nongnu.org; Wed, 05 May 2010 10:28:42 -0400 Received: from [140.186.70.92] (port=50019 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9faa-0004sL-CB for qemu-devel@nongnu.org; Wed, 05 May 2010 10:28:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9faY-00069z-Qg for qemu-devel@nongnu.org; Wed, 05 May 2010 10:28:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20351) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9faY-00069o-Ie for qemu-devel@nongnu.org; Wed, 05 May 2010 10:28:38 -0400 Message-ID: <4BE18078.5040800@redhat.com> Date: Wed, 05 May 2010 16:28:08 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] simple block driver cleanups References: <20100504104351.GA6342@lst.de> <4BE0152F.3060109@redhat.com> <20100504132218.GA12186@lst.de> In-Reply-To: <20100504132218.GA12186@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 04.05.2010 15:22, schrieb Christoph Hellwig: > On Tue, May 04, 2010 at 02:38:07PM +0200, Kevin Wolf wrote: >> Am 04.05.2010 12:43, schrieb Christoph Hellwig: >>> This series cleans up the simple read-only block drivers to use the >>> qemu block device API to access their backing devices, making the code >>> simpler and usable over nbd/curl. I've not touched dmg yet as it's even >>> more bitrot than usual and deserves it's own series. >> >> Have you already added something to qemu-iotests locally to test this or >> did you test manually? > > I tested cloop manually, I haven't found usable creation tools for the > others yet. Okay, so I have reviewed the patches now and except for that one thing in parallels they look good. For cloop I trust your test, and for bochs I did a very basic test myself (however, I doubt that anyone uses this driver, considering how hard it is to create such an image...). For parallels I still need to find out how to create an image. I've applied cloop and bochs to the block branch, and I'll wait for a v2 with the parallels patches. Kevin