From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O9kix-0003fp-3d
	for qemu-devel@nongnu.org; Wed, 05 May 2010 15:57:39 -0400
Received: from [140.186.70.92] (port=53686 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O9kiu-0002Yu-Sm
	for qemu-devel@nongnu.org; Wed, 05 May 2010 15:57:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O9kUX-0007fn-Lv
	for qemu-devel@nongnu.org; Wed, 05 May 2010 15:42:46 -0400
Received: from mail-yw0-f198.google.com ([209.85.211.198]:42345)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1O9kUX-0007fi-IK
	for qemu-devel@nongnu.org; Wed, 05 May 2010 15:42:45 -0400
Received: by ywh36 with SMTP id 36so2441493ywh.4
	for <qemu-devel@nongnu.org>; Wed, 05 May 2010 12:42:45 -0700 (PDT)
Message-ID: <4BE1CA28.5040208@codemonkey.ws>
Date: Wed, 05 May 2010 14:42:32 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] Count "logo" keys as modifier keys
References: <1273033029-15622-1-git-send-email-anomie@users.sourceforge.net>
	<1273033029-15622-3-git-send-email-anomie@users.sourceforge.net>
In-Reply-To: <1273033029-15622-3-git-send-email-anomie@users.sourceforge.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Jorsch <anomie@users.sourceforge.net>
Cc: qemu-devel@nongnu.org

On 05/04/2010 11:17 PM, Brad Jorsch wrote:
> These are often mapped to Meta on Linux. And I for one use Meta-Tab as
> the equivalent of Windows's Alt-Tab, so not having it marked as a
> modifier leaves the guest thinking it's permanently pressed.
>
> Signed-off-by: Brad Jorsch<anomie@users.sourceforge.net>
>    

Seems reasonable.

Regards,

Anthony Liguori

> ---
>   sdl.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sdl.c b/sdl.c
> index c155113..cc7b1bb 100644
> --- a/sdl.c
> +++ b/sdl.c
> @@ -385,6 +385,8 @@ static void sdl_process_key(SDL_KeyboardEvent *ev)
>       case 0x9d:                          /* Right CTRL */
>       case 0x38:                          /* Left ALT */
>       case 0xb8:                         /* Right ALT */
> +    case 0xdb:                          /* Left META */
> +    case 0xdc:                         /* Right META */
>           if (ev->type == SDL_KEYUP)
>               modifiers_state[keycode] = 0;
>           else
>