From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OA6yE-0004va-8Q
	for qemu-devel@nongnu.org; Thu, 06 May 2010 15:42:54 -0400
Received: from [140.186.70.92] (port=34411 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OA6y7-0003lp-33
	for qemu-devel@nongnu.org; Thu, 06 May 2010 15:42:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OA6jj-0001Hv-Lb
	for qemu-devel@nongnu.org; Thu, 06 May 2010 15:28:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34401)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1OA6jj-0001Ho-E6
	for qemu-devel@nongnu.org; Thu, 06 May 2010 15:27:55 -0400
Message-ID: <4BE31833.5000904@redhat.com>
Date: Thu, 06 May 2010 21:27:47 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] cursor: add cursor functions.
References: <1273063904-6028-1-git-send-email-kraxel@redhat.com>	
	<1273063904-6028-2-git-send-email-kraxel@redhat.com>
	<u2qf43fc5581005061112y316555c7j3e69b22a122b5ed2@mail.gmail.com>
In-Reply-To: <u2qf43fc5581005061112y316555c7j3e69b22a122b5ed2@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

>>   +static const char cursor_left_ptr_32[32*32] = {
>>   +    "                                "
>>   +    " X                              "
>>   +    " XX                             "
>>   +    " X.X                            "
>>   +    " X..X                           "
>>   +    " X...X                          "
>>   +    " X....X                         "
>>   +    " X.....X                        "
>>   +    " X......X                       "
>>   +    " X.......X                      "
>>   +    " X........X                     "
>>   +    " X.....XXXXX                    "
>>   +    " X..X..X                        "
>>   +    " X.X X..X                       "
>>   +    " XX  X..X                       "
>>   +    " X    X..X                      "
>>   +    "      X..X                      "
>>   +    "       X..X                     "
>>   +    "       X..X                     "
>>   +    "        XX                      "
>>   +    "                                "
>>   +};
>
> Is this format standard?

Inspiried by xpm but simplified a bit as full xpm support just for a 
built-in fallback cursor would have been overkill.  The nice thing about 
xpm is that you can use any text editor for editing icons.

> How about using X bitmap format instead:
> $ cat /usr/include/X11/bitmaps/left_ptr

> Then there would be no need of parsing.

Well.  You still would have to convert it as qemu internal cursor format 
is defined as 32bit depth, rgb with alpha channel.  So it doesn't buy 
you that much.

cheers,
   Gerd