From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OAIPj-0007EI-NP for qemu-devel@nongnu.org; Fri, 07 May 2010 03:56:03 -0400 Received: from [140.186.70.92] (port=50894 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OAIPi-0007AX-1m for qemu-devel@nongnu.org; Fri, 07 May 2010 03:56:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OAIPg-0008T1-Aj for qemu-devel@nongnu.org; Fri, 07 May 2010 03:56:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17250) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OAIPg-0008Sq-2Y for qemu-devel@nongnu.org; Fri, 07 May 2010 03:56:00 -0400 Message-ID: <4BE3C76B.3020301@redhat.com> Date: Fri, 07 May 2010 09:55:23 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4BE304DE.3060200@mail.berlios.de> <1273170570-20087-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1273170570-20087-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: =?UTF-8?B?RnJhbsOnb2lzIFJldm8=?=@gnu.org, QEMU Developers , =?UTF-8?B?bA==?= Am 06.05.2010 20:29, schrieb Stefan Weil: > This patch fixes a regression introduced by commit > 95a2f9bc588c3f83375d87b0a9394f89a1bcfada. > > The fix is based on a patch from Kevin Wolf. Here his comment: > > "The number of blocks needs to be rounded up to cover all of the virtual hard > disk. Without this fix, we can't even open our own images if their size is not > a multiple of the block size." > > While Kevin's patch addressed vdi_create, my modification also fixes > vdi_open which now accepts any image which is large enough to hold > the blocks. Shouldn't it be the other way round? That is, an image which has some unused blocks at its end makes sense, whereas an image with a virtual disk size that can't be represented with the number of blocks doesn't? > I also decided to keep the original code in vdi_create which rounds down. > Rounding works in both directions, and there are good arguments for both, > so I just left the original simple code. > > It is very important to use the rounded value for the new disk size, too - > otherwise VirtualBox cannot open our disk image. So you're saying that in VDI you can't represent disks with an odd size? The one thing common across image formats seems to be that they are broken... Kevin