[Qemu-devel] Re: Registering buffers with a qdict

[Jan Kiszka <jan.kiszka@siemens.com>]

Luiz Capitulino wrote:
> On Fri, 07 May 2010 13:45:03 +0200
> Jan Kiszka <jan.kiszka@siemens.com> wrote:
> 
>> Hi Luiz,
>>
>> what is the recommended way of pushing larger buffers (up to 64K so far)
>> into a qdict? QLIST of QINT (one per byte) looks a bit heavy. I thought
>> about hex-encoding the content first (series of "%02X"), then
>> registering it as QSTRING. Or should we introduce a new type, QBUFFER?
> 
>  I don't think that hex-encoding the contents is so bad if your use case is
> very specific and isolated.

The focus will be first on visualizing the buffer (user_print), but who
knows what happens once the services is also exposed via QMP.

> 
>  On the other hand, I do prefer a QBuffer type, specially because we can
> have buffer operations.

The q<type>.c files look sufficiently simply, guess I will add a buffer
type. Still, hex-encoding is probably the best representation for QMP.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux