From: Jan Kiszka <jan.kiszka@web.de>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()
Date: Fri, 07 May 2010 23:55:20 +0200 [thread overview]
Message-ID: <4BE48C48.5000100@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Luiz,
I missed this when the API was first proposed:
cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new APIs
should not rely it.
I just realized that monitor_cur_is_qmp() does so. It should be
refactored to monitor_is_qmp(Monitor *mon). And qerror should be enhance
by a 'mon' argument as well. Callers that aren't passed a 'mon'
themselves should either be fixed at this chance or could fall back to
cur_mon for the time being.
So far for the theory - do you see any pitfalls in the existing usage?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next reply other threads:[~2010-05-07 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 21:55 Jan Kiszka [this message]
2010-05-10 9:40 ` [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report() Markus Armbruster
2010-05-10 10:12 ` Jan Kiszka
2010-05-10 11:14 ` Markus Armbruster
2010-05-10 12:23 ` Jan Kiszka
2010-05-10 13:11 ` Luiz Capitulino
2010-05-10 13:16 ` Markus Armbruster
2010-05-10 13:26 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE48C48.5000100@web.de \
--to=jan.kiszka@web.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).