From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OAVW6-0003xc-Lj
	for qemu-devel@nongnu.org; Fri, 07 May 2010 17:55:30 -0400
Received: from [140.186.70.92] (port=60819 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OAVW5-0003uh-4s
	for qemu-devel@nongnu.org; Fri, 07 May 2010 17:55:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1OAVW3-0005GR-QQ
	for qemu-devel@nongnu.org; Fri, 07 May 2010 17:55:29 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:55705)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1OAVW3-0005GE-HB
	for qemu-devel@nongnu.org; Fri, 07 May 2010 17:55:27 -0400
Message-ID: <4BE48C48.5000100@web.de>
Date: Fri, 07 May 2010 23:55:20 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig0D473ED3C14C8D8D5259F230"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0D473ED3C14C8D8D5259F230
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Luiz,

I missed this when the API was first proposed:

cur_mon is scheduled for removal (one day...). It's just an intermediate
step to convert all users to explicit 'mon' passing. Thus, new APIs
should not rely it.

I just realized that monitor_cur_is_qmp() does so. It should be
refactored to monitor_is_qmp(Monitor *mon). And qerror should be enhance
by a 'mon' argument as well. Callers that aren't passed a 'mon'
themselves should either be fixed at this chance or could fall back to
cur_mon for the time being.

So far for the theory - do you see any pitfalls in the existing usage?

Jan


--------------enig0D473ED3C14C8D8D5259F230
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkvkjE0ACgkQitSsb3rl5xSv0ACgwGtVQGe06nVXoZ/HlwdnCKSZ
tlUAn3ycrHKHB3FWo6M3OKKDMnprQpLH
=Gb3W
-----END PGP SIGNATURE-----

--------------enig0D473ED3C14C8D8D5259F230--