From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OBBuJ-0005pQ-68
	for qemu-devel@nongnu.org; Sun, 09 May 2010 15:11:19 -0400
Received: from [140.186.70.92] (port=35535 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBBuG-0005pI-PX
	for qemu-devel@nongnu.org; Sun, 09 May 2010 15:11:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OBBuF-0003DQ-2d
	for qemu-devel@nongnu.org; Sun, 09 May 2010 15:11:16 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54069 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OBBuE-0003D0-SL
	for qemu-devel@nongnu.org; Sun, 09 May 2010 15:11:15 -0400
Message-ID: <4BE708D5.5080405@suse.de>
Date: Sun, 09 May 2010 21:11:17 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1945C1D2D39F43239CFD537CA66DA5F8@FSCPC>
In-Reply-To: <1945C1D2D39F43239CFD537CA66DA5F8@FSCPC>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: AHCI support integration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: =?UTF-8?B?5LmU5bSH?= <qiaochong@loongson.cn>, teheo@suse.de, Joerg Roedel <joro@8bytes.org>, qemu-devel@nongnu.org, Elek Roland <elek.roland@gmail.com>

Sebastian Herbszt wrote:
> The ICH6 AHCI implementation submitted by Chong is an all-in-one
> attempt (ahci.c).
> It includes all needed parts of the ICH6, AHCI, SATA and ATA
> specification.
> The code in hw/ide/* on the other hand is split (or could be split)
> into smaller parts like
> port based and bus master access, IDE and ATA core.
> I think it might be reasonable to split ahci.c into ICH6, AHCI and
> SATA parts and strip the
> limited ATA support and reuse it from the ide core.
> This would give us something like the following:
>
> hw/ide/piix.c (PIIX3 and PIIX4)
> hw/ide/pci.c and core.c (IDE, BM)
> hw/ata-core.c (ATA)
> hw/sata/ich6.c (ICH6)
> hw/sata-core.c (SATA)
> hw/ahci-core.c (AHCI)
>
> Should this be a goal or am i over-engineering here?

[CC'ing Tejun - he volunteered to help out on this topic as well]

I think there's no need to split sata and ahci.
Apart from that, I think we should take things incrementally. For now
there's no need to split IDE further until we hit a technical limit. I
have yet to see a patch trying to reuse the IDE command processing, so
depending on how the respective person implements that, I'm open to
suggenstions.

So as far as I'm concerned, I'd prefer to model things after they're
developed. That way we know the pitfalls.


Alex