From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36938 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBUk5-0001jY-9H
	for qemu-devel@nongnu.org; Mon, 10 May 2010 11:18:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OBUjz-0000K9-Fa
	for qemu-devel@nongnu.org; Mon, 10 May 2010 11:18:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35315)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OBUjz-0000Jz-7z
	for qemu-devel@nongnu.org; Mon, 10 May 2010 11:17:55 -0400
Message-ID: <4BE8239F.6000207@redhat.com>
Date: Mon, 10 May 2010 18:17:51 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1271872408-22842-1-git-send-email-cam@cs.ualberta.ca>	
	<1271872408-22842-2-git-send-email-cam@cs.ualberta.ca>	
	<1271872408-22842-3-git-send-email-cam@cs.ualberta.ca>	
	<1271872408-22842-4-git-send-email-cam@cs.ualberta.ca>	
	<4BE7E347.9050705@redhat.com>
	<AANLkTim73IiS8gwldxkpSoQIiR3dbpx54YwxWCpXp37X@mail.gmail.com>
In-Reply-To: <AANLkTim73IiS8gwldxkpSoQIiR3dbpx54YwxWCpXp37X@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning
	ioeventfd and irqfds.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On 05/10/2010 06:13 PM, Cam Macdonell wrote:
>
>>> +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t addr, uint32_t val, bool
>>> assign)
>>> +{
>>> +
>>> +    int ret;
>>> +    struct kvm_ioeventfd iofd;
>>> +
>>> +    iofd.datamatch = val;
>>> +    iofd.addr = addr;
>>> +    iofd.len = 4;
>>> +    iofd.flags = KVM_IOEVENTFD_FLAG_DATAMATCH;
>>> +    iofd.fd = fd;
>>> +
>>> +    if (!kvm_enabled())
>>> +        return -ENOSYS;
>>> +    if (!assign)
>>> +        iofd.flags |= KVM_IOEVENTFD_FLAG_DEASSIGN;
>>>
>>>        
>> May be more usable to have separate assign and deassign functions (that can
>> call into a single internal implementation).
>>      
> I believe the convention so far is to use the 'assign' flag as
> Michael's patch and the PIO version kvm_set_ioeventfd_pio_word() do.
>    

I dislike bool arguments since they're hard to understand at the call 
site.  However if there's precedent we can stick to it and perhaps 
change it all later.

-- 
error compiling committee.c: too many arguments to function