From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60524 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBltF-0005e8-2Y for qemu-devel@nongnu.org; Tue, 11 May 2010 05:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBltA-0000Je-1N for qemu-devel@nongnu.org; Tue, 11 May 2010 05:36:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19695) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBlt9-0000JS-Ob for qemu-devel@nongnu.org; Tue, 11 May 2010 05:36:31 -0400 Message-ID: <4BE92519.9070400@redhat.com> Date: Tue, 11 May 2010 11:36:25 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init() References: <20100510150016.15398.36521.stgit@virtlab9.virt.bos.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org On 05/11/10 11:25, Markus Armbruster wrote: > Alex Williamson writes: > >> If the init function of a device fails, as might happen with device >> assignment, we never undo the work done by do_pci_register_device(). >> This not only causes a bit of a memory leak, but also leaves a bogus >> pointer in the bus devices array that can cause a segfault or >> garbage data from 'info pci'. >> >> Signed-off-by: Alex Williamson > > Looks good to me. Gerd? Yes, looks fine. cheers, Gerd