From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43162 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBm3J-0007qv-C0 for qemu-devel@nongnu.org; Tue, 11 May 2010 05:47:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBm3H-0002Wr-TE for qemu-devel@nongnu.org; Tue, 11 May 2010 05:47:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27354) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBm3H-0002WS-Lf for qemu-devel@nongnu.org; Tue, 11 May 2010 05:46:59 -0400 Message-ID: <4BE92777.5040008@redhat.com> Date: Tue, 11 May 2010 11:46:31 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1273520786-10385-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1273520786-10385-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] block/vpc: Fix conversion from size to disk geometry List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org Am 10.05.2010 21:46, schrieb Stefan Weil: > The VHD algorithm calculates a disk geometry > which is usually smaller than the requested size. > > QEMU tried to round up but failed for certain sizes: > > qemu-img create -f vpc disk.vpc 9437184 > would create an image with 9435136 bytes > (which is too small for qemu-img convert). > > Instead of hacking the geometry algorithm, the patch > increases the number of sectors until we get enough > sectors. > > Cc: Kevin Wolf > Signed-off-by: Stefan Weil Thanks, applied to the block branch. Kevin