From: Kevin Wolf <kwolf@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y
Date: Tue, 11 May 2010 13:52:58 +0200 [thread overview]
Message-ID: <4BE9451A.2060804@redhat.com> (raw)
In-Reply-To: <967a05760ff3819dd26ae0e9e2fb2062e34c265f.1273576209.git.quintela@redhat.com>
Am 11.05.2010 13:13, schrieb Juan Quintela:
> This variable contains the objects shared between tools and qemu binary.
> Add qemu-error.o only in one place, it "could" be built in two places
> depending of make ordering.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -39,16 +39,19 @@ fsdev-nested-$(CONFIG_LINUX) = qemu-fsdev.o
> fsdev-obj-$(CONFIG_LINUX) += $(addprefix fsdev/, $(fsdev-nested-y))
>
> ######################################################################
> +# shared-obj-y has the object that are shared by qemu binary and tools
> +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y)
Currently, block-obj-y contains some more files which are not really
related to the block layer, such as cutils.o or osdep.o. Should they be
moved here while we're at it?
Kevin
next prev parent reply other threads:[~2010-05-11 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 11:13 [Qemu-devel] [PATCH 0/2] Makefile: remoeve duplicate qemu-error.o Juan Quintela
2010-05-11 11:13 ` [Qemu-devel] [PATCH 1/2] Create shared-obj-y Juan Quintela
2010-05-11 11:45 ` Markus Armbruster
2010-05-11 11:52 ` Kevin Wolf [this message]
2010-05-11 12:07 ` Markus Armbruster
2010-05-11 12:17 ` [Qemu-devel] " Juan Quintela
2010-05-11 11:13 ` [Qemu-devel] [PATCH 2/2] state that fsdev depends on LINUX only once Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE9451A.2060804@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).