From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33355 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBo1g-0001xF-FJ
	for qemu-devel@nongnu.org; Tue, 11 May 2010 07:53:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OBo1c-0004d9-IW
	for qemu-devel@nongnu.org; Tue, 11 May 2010 07:53:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37880)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OBo1c-0004d1-BJ
	for qemu-devel@nongnu.org; Tue, 11 May 2010 07:53:24 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4BBrMbE008802
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 11 May 2010 07:53:23 -0400
Message-ID: <4BE9451A.2060804@redhat.com>
Date: Tue, 11 May 2010 13:52:58 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] Create shared-obj-y
References: <cover.1273576209.git.quintela@redhat.com>
	<967a05760ff3819dd26ae0e9e2fb2062e34c265f.1273576209.git.quintela@redhat.com>
In-Reply-To: <967a05760ff3819dd26ae0e9e2fb2062e34c265f.1273576209.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Am 11.05.2010 13:13, schrieb Juan Quintela:
> This variable contains the objects shared between tools and qemu binary.
> Add qemu-error.o only in one place, it "could" be built in two places
> depending of make ordering.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -39,16 +39,19 @@ fsdev-nested-$(CONFIG_LINUX) = qemu-fsdev.o
>  fsdev-obj-$(CONFIG_LINUX) += $(addprefix fsdev/, $(fsdev-nested-y))
> 
>  ######################################################################
> +# shared-obj-y has the object that are shared by qemu binary and tools
> +shared-obj-y = qemu-error.o $(block-obj-y) $(qobject-obj-y)

Currently, block-obj-y contains some more files which are not really
related to the block layer, such as cutils.o or osdep.o. Should they be
moved here while we're at it?

Kevin