qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Bastian Blank <waldi@debian.org>,
	Aurelien Jarno <aurelien@aurel32.net>,
	qemu-devel Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read
Date: Tue, 11 May 2010 18:35:08 +0200	[thread overview]
Message-ID: <4BE9873C.9050301@suse.de> (raw)
In-Reply-To: <4BE98600.5030905@siemens.com>

Jan Kiszka wrote:
> Alexander Graf wrote:
>   
>> Jan Kiszka wrote:
>>     
>>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the
>>> latter is called periodically, the former will only be invoked when new
>>> characters arrive at the back-end. This caused problems to front-end
>>> drivers whenever they were unable to read data immediately, e.g.
>>> virtio-console attached to stdio.
>>>   
>>>       
>> I don't see this patch applied, but also don't see any issues with
>> virtio-console anymore on today's git. Odd.
>>
>>     
>
> Hmm, I had a clear before-after experience using virtio console with an
> x86 Linux guest. I still think my patch is correct and required. Maybe
> you can bisect this positive "regression"? Something might paper over
> the core issue now.
>   

I just did a git reset --hard on
baf0b55a9e57b909b1f8b0f732c0b10242867418 and it worked! What the ...

Alex

  reply	other threads:[~2010-05-11 16:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 16:56 [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs Alexander Graf
2010-05-04 13:44 ` Anthony Liguori
2010-05-04 14:30   ` Alexander Graf
2010-05-04 14:34     ` Anthony Liguori
2010-05-04 16:01       ` Alexander Graf
2010-05-04 16:25         ` Anthony Liguori
2010-05-04 16:49           ` Jan Kiszka
2010-05-05  7:33             ` [Qemu-devel] " Jan Kiszka
2010-05-05  8:08               ` Jan Kiszka
2010-05-05 12:46                 ` Alexander Graf
2010-05-05 15:27                 ` [Qemu-devel] [PATCH] char: Flush read buffer in mux_chr_can_read Jan Kiszka
2010-05-11 16:22                   ` [Qemu-devel] " Alexander Graf
2010-05-11 16:29                     ` Jan Kiszka
2010-05-11 16:35                       ` Alexander Graf [this message]
2010-05-12 18:51                         ` Jan Kiszka
2010-05-14 16:00                           ` Alexander Graf
2010-05-14 16:17                             ` Jan Kiszka
2010-05-15  5:31                               ` Alexander Graf
2010-05-15  8:36                                 ` Jan Kiszka
2010-05-15  8:37                                   ` Alexander Graf
2010-05-15  8:54                                     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE9873C.9050301@suse.de \
    --to=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=waldi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).