qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Alexander Graf <agraf@suse.de>,
	Aurelien Jarno <aurelien@aurel32.net>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub	(tcg_out_reloc)
Date: Tue, 11 May 2010 10:26:58 -0700	[thread overview]
Message-ID: <4BE99362.3070706@twiddle.net> (raw)
In-Reply-To: <4BE98A13.1040103@mail.berlios.de>

On 05/11/2010 09:47 AM, Stefan Weil wrote:
> Won't you get another warning about unreachable code
> because tcg_abort never returns?

We don't enable that warning.

> What about condition compilation for tcg_out_reloc
> (don't compile it for hosts which don't need it)?

All hosts should need it.  S390 doesn't only because
it's all stubbed out.

Frankly, it shouldn't take much effort to get a working
TCG for s390x...


r~

  reply	other threads:[~2010-05-11 17:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11 16:23 [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub (tcg_out_reloc) Alexander Graf
2010-05-11 16:47 ` Stefan Weil
2010-05-11 17:26   ` Richard Henderson [this message]
2010-05-11 19:50     ` Alexander Graf
2010-05-12 17:28       ` Aurelien Jarno
2010-05-12 22:52         ` Alexander Graf
2010-05-21 16:46 ` Aurelien Jarno
2010-05-21 17:00   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE99362.3070706@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).