From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55373 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBtEx-0006bm-4o
	for qemu-devel@nongnu.org; Tue, 11 May 2010 13:27:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1OBtEo-00033t-Cc
	for qemu-devel@nongnu.org; Tue, 11 May 2010 13:27:27 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:61674)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth7680@gmail.com>) id 1OBtEm-00033I-6F
	for qemu-devel@nongnu.org; Tue, 11 May 2010 13:27:22 -0400
Received: by gyd5 with SMTP id 5so2762858gyd.4
	for <qemu-devel@nongnu.org>; Tue, 11 May 2010 10:27:18 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4BE99362.3070706@twiddle.net>
Date: Tue, 11 May 2010 10:26:58 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg
	stub	(tcg_out_reloc)
References: <1273595012-19587-1-git-send-email-agraf@suse.de>
	<4BE98A13.1040103@mail.berlios.de>
In-Reply-To: <4BE98A13.1040103@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Alexander Graf <agraf@suse.de>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

On 05/11/2010 09:47 AM, Stefan Weil wrote:
> Won't you get another warning about unreachable code
> because tcg_abort never returns?

We don't enable that warning.

> What about condition compilation for tcg_out_reloc
> (don't compile it for hosts which don't need it)?

All hosts should need it.  S390 doesn't only because
it's all stubbed out.

Frankly, it shouldn't take much effort to get a working
TCG for s390x...


r~