From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33604 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBukv-0004Q3-Ni for qemu-devel@nongnu.org; Tue, 11 May 2010 15:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBuku-0005X7-1l for qemu-devel@nongnu.org; Tue, 11 May 2010 15:04:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61685) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBukt-0005X0-QR for qemu-devel@nongnu.org; Tue, 11 May 2010 15:04:36 -0400 Message-ID: <4BE9AA3C.5040108@redhat.com> Date: Tue, 11 May 2010 22:04:28 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add flush=off parameter to -drive References: <1273528310-7051-1-git-send-email-agraf@suse.de> <1273528310-7051-2-git-send-email-agraf@suse.de> <1273528310-7051-3-git-send-email-agraf@suse.de> <4BE91708.7050307@redhat.com> In-Reply-To: <4BE91708.7050307@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: hch@lst.de, Alexander Graf , qemu-devel@nongnu.org On 05/11/2010 11:36 AM, Kevin Wolf wrote: > Am 10.05.2010 23:51, schrieb Alexander Graf: > >> Usually the guest can tell the host to flush data to disk. In some cases we >> don't want to flush though, but try to keep everything in cache. >> >> So let's add a new parameter to -drive that allows us to set the flushing >> behavior to "on" or "off", defaulting to enabling the guest to flush. >> >> Signed-off-by: Alexander Graf >> > What about another cache=... value instead of adding more options? I'm > quite sure you'll only ever need this with writeback caching. So we > could have cache=none|writethrough|writeback|wb-noflush or something > like that. > I implemented this once and promptly forgot about it, as cache=volatile. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.