From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48541 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCCwE-0004uu-A9 for qemu-devel@nongnu.org; Wed, 12 May 2010 10:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCCwB-0000V7-Gu for qemu-devel@nongnu.org; Wed, 12 May 2010 10:29:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22970) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCCw3-0000TZ-Uj for qemu-devel@nongnu.org; Wed, 12 May 2010 10:29:23 -0400 Message-ID: <4BEABB0F.9030907@redhat.com> Date: Wed, 12 May 2010 17:28:31 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1273661213-19611-1-git-send-email-morita.kazutaka@lab.ntt.co.jp> <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> In-Reply-To: <1273661213-19611-2-git-send-email-morita.kazutaka@lab.ntt.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC PATCH 1/2] close all the block drivers before the qemu process exits List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MORITA Kazutaka Cc: fujita.tomonori@lab.ntt.co.jp, aliguori@us.ibm.com, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, kvm@vger.kernel.org On 05/12/2010 01:46 PM, MORITA Kazutaka wrote: > This patch calls the close handler of the block driver before the qemu > process exits. > > This is necessary because the sheepdog block driver releases the lock > of VM images in the close handler. > > How do you handle abnormal termination? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.