From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX.
Date: Wed, 12 May 2010 07:48:10 -0700 [thread overview]
Message-ID: <4BEABFAA.8060705@twiddle.net> (raw)
In-Reply-To: <AANLkTinlMv-waAIcLQQi6mY_Gw4miA6g7cWsotMctVfA@mail.gmail.com>
> The new code doesn't update dc->cc_op, shouldn't that happen if the
> condition codes are changed? For example 'addx' in the sequence
> 'addcc; addxcc; addx;' should need the C flag from the second addxcc,
> not from first addcc.
Oops, yes, that needs updating too. Will fix.
r~
next prev parent reply other threads:[~2010-05-12 14:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 22:23 [Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements Richard Henderson
2010-05-10 22:23 ` [Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug Richard Henderson
2010-05-10 22:23 ` [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation Richard Henderson
2010-05-11 19:14 ` [Qemu-devel] " Blue Swirl
2010-05-11 21:31 ` [Qemu-devel] " Artyom Tarasenko
2010-05-12 14:56 ` Richard Henderson
2010-05-12 15:18 ` Artyom Tarasenko
2010-05-12 17:08 ` Richard Henderson
2010-05-12 15:04 ` Richard Henderson
2010-05-10 22:23 ` [Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX Richard Henderson
2010-05-11 19:28 ` [Qemu-devel] " Blue Swirl
2010-05-12 14:48 ` Richard Henderson [this message]
2010-05-12 18:04 ` [Qemu-devel] [PATCH 0/3] Fix ADDX compilation plus improvements, v2 Richard Henderson
2010-05-12 18:04 ` [Qemu-devel] [PATCH 1/3] target-sparc: Fix compilation with --enable-debug Richard Henderson
2010-05-12 18:04 ` [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation Richard Henderson
2010-05-14 9:04 ` [Qemu-devel] " Artyom Tarasenko
2010-05-12 18:04 ` [Qemu-devel] [PATCH 3/3] target-sparc: Inline some generation of carry for ADDX/SUBX Richard Henderson
2010-05-20 19:59 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEABFAA.8060705@twiddle.net \
--to=rth@twiddle.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).