From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55100 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCDEQ-0004v9-JA
	for qemu-devel@nongnu.org; Wed, 12 May 2010 10:48:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OCDEN-0003gk-Ls
	for qemu-devel@nongnu.org; Wed, 12 May 2010 10:48:18 -0400
Received: from are.twiddle.net ([75.149.56.221]:53365)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OCDEN-0003gC-AV
	for qemu-devel@nongnu.org; Wed, 12 May 2010 10:48:15 -0400
Message-ID: <4BEABFAA.8060705@twiddle.net>
Date: Wed, 12 May 2010 07:48:10 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1273529974.git.rth@twiddle.net>	
	<aabfc3eb39190fad8837e3bf1abd5e0f09eda5d4.1273529974.git.rth@twiddle.net>
	<AANLkTinlMv-waAIcLQQi6mY_Gw4miA6g7cWsotMctVfA@mail.gmail.com>
In-Reply-To: <AANLkTinlMv-waAIcLQQi6mY_Gw4miA6g7cWsotMctVfA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] target-sparc: Inline some generation
 of carry for ADDX/SUBX.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

> The new code doesn't update dc->cc_op, shouldn't that happen if the
> condition codes are changed? For example 'addx' in the sequence
> 'addcc; addxcc; addx;' should need the C flag from the second addxcc,
> not from first addcc.

Oops, yes, that needs updating too.  Will fix.


r~