From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33884 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCDMD-0008Cy-Sv for qemu-devel@nongnu.org; Wed, 12 May 2010 10:56:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCDM6-0004zE-RS for qemu-devel@nongnu.org; Wed, 12 May 2010 10:56:21 -0400 Received: from are.twiddle.net ([75.149.56.221]:60212) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCDM5-0004yo-Tu for qemu-devel@nongnu.org; Wed, 12 May 2010 10:56:14 -0400 Message-ID: <4BEAC18C.80208@twiddle.net> Date: Wed, 12 May 2010 07:56:12 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] target-sparc: Simplify ICC generation; fix ADDX carry generation. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org On 05/11/2010 02:31 PM, Artyom Tarasenko wrote: > Nack. It looks like you reverted carry generation to the previous > (broken) behavior. Oh? I suppose I should go back and look at the logs, but the way it's written there sure seems to match 5.1.5.1 of the sparcv9 manual: You'll only get carry into the high bit on X - Y if X < Y. In any case, if you meant to fix carry computation for subtraction, you missed changing the 64-bit carry computation too. It is still written the same way before and after my patch, and matches both the expectation I have from the v9 manual and the post-patch code along the 32-bit path. r~