From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3 v2] dmg: use qemu block API
Date: Wed, 12 May 2010 17:51:43 +0200 [thread overview]
Message-ID: <4BEACE8F.5010205@redhat.com> (raw)
In-Reply-To: <20100512143149.GB13686@lst.de>
Am 12.05.2010 16:31, schrieb Christoph Hellwig:
> Use bdrv_pwrite to access the backing device instead of pread, and
> convert the driver to implementing the bdrv_open method which gives
> it an already opened BlockDriverState for the underlying device.
>
> Dmg actually does an lseek to a negative offset in the open routine,
> which we replace with offset arithmetics after doing a bdrv_getlength.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks, applied all to the block branch.
Kevin
prev parent reply other threads:[~2010-05-12 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 14:55 [Qemu-devel] [PATCH 0/3] dmg updates Christoph Hellwig
2010-05-07 14:55 ` [Qemu-devel] [PATCH 1/3] dmg: fix reading of uncompressed chunks Christoph Hellwig
2010-05-07 14:56 ` [Qemu-devel] [PATCH 2/3] dmg: use pread Christoph Hellwig
2010-05-10 10:07 ` Kevin Wolf
2010-05-10 20:20 ` Christoph Hellwig
2010-05-11 8:00 ` Kevin Wolf
2010-05-12 14:31 ` [Qemu-devel] [PATCH 2/3 v2] " Christoph Hellwig
2010-05-07 14:56 ` [Qemu-devel] [PATCH 3/3] dmg: use qemu block API Christoph Hellwig
2010-05-12 14:31 ` [Qemu-devel] [PATCH 3/3 v2] " Christoph Hellwig
2010-05-12 15:51 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEACE8F.5010205@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).