From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49253 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCH1c-00010F-S3 for qemu-devel@nongnu.org; Wed, 12 May 2010 14:51:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCH1a-00014d-NH for qemu-devel@nongnu.org; Wed, 12 May 2010 14:51:20 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:59056) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCH1a-00014O-Ci for qemu-devel@nongnu.org; Wed, 12 May 2010 14:51:18 -0400 Message-ID: <4BEAF898.3020001@web.de> Date: Wed, 12 May 2010 20:51:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1271782566-16420-1-git-send-email-agraf@suse.de> <4BE024A9.2040904@codemonkey.ws> <16E7906F-F39B-4121-B540-E2F0E67D405E@suse.de> <4BE0307C.1010305@codemonkey.ws> <0D8C0E80-5325-4E50-A2EF-E73BB95AD8DA@suse.de> <4BE04A78.6070505@codemonkey.ws> <4BE05034.9060803@siemens.com> <4BE11F54.1030900@web.de> <4BE12763.8000809@web.de> <4BE18E60.8070709@siemens.com> <4BE98445.9000203@suse.de> <4BE98600.5030905@siemens.com> <4BE9873C.9050301@suse.de> In-Reply-To: <4BE9873C.9050301@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7EC20C66892339220C479E05" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Bastian Blank , qemu-devel Developers , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7EC20C66892339220C479E05 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Alexander Graf wrote: > Jan Kiszka wrote: >> Alexander Graf wrote: >> =20 >>> Jan Kiszka wrote: >>> =20 >>>> Move the buffer flush from mux_chr_read to mux_chr_can_read. While t= he >>>> latter is called periodically, the former will only be invoked when = new >>>> characters arrive at the back-end. This caused problems to front-end= >>>> drivers whenever they were unable to read data immediately, e.g. >>>> virtio-console attached to stdio. >>>> =20 >>>> =20 >>> I don't see this patch applied, but also don't see any issues with >>> virtio-console anymore on today's git. Odd. >>> >>> =20 >> Hmm, I had a clear before-after experience using virtio console with a= n >> x86 Linux guest. I still think my patch is correct and required. Maybe= >> you can bisect this positive "regression"? Something might paper over >> the core issue now. >> =20 >=20 > I just did a git reset --hard on > baf0b55a9e57b909b1f8b0f732c0b10242867418 and it worked! What the ... Whatever "worked" now means (I'm slightly confused), I just rechecked the situation over current git head ("qemu linux-guest.img -chardev stdio,id=3Dcons,mux=3Don -device virtio-serial -device virtconsole,chardev=3Dcons -mon chardev=3Dcons", "cat /dev/hvc0" in the guest, typing some chars on the host console): The problem still persists, my patch still solves it. Can you confirm this, ideally also for s390? Jan --------------enig7EC20C66892339220C479E05 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvq+KAACgkQitSsb3rl5xRezQCfTvJkdeD6XP3Ix24vGDKH8eaN SGgAniyRAGIvy6mDfXqsbwK02LTqM/OX =d1D7 -----END PGP SIGNATURE----- --------------enig7EC20C66892339220C479E05--