From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59353 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCH6q-00046z-IP
	for qemu-devel@nongnu.org; Wed, 12 May 2010 14:56:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OCH6m-0001ph-Mf
	for qemu-devel@nongnu.org; Wed, 12 May 2010 14:56:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27268)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1OCH6m-0001pD-Cs
	for qemu-devel@nongnu.org; Wed, 12 May 2010 14:56:40 -0400
Message-ID: <4BEAF9CB.1080909@redhat.com>
Date: Wed, 12 May 2010 20:56:11 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <4BE90CB6.50709@redhat.com>
	<1273688745-8828-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1273688745-8828-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] block/vdi: Fix image opening and creation
 for odd disk sizes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: =?UTF-8?B?RnJhbsOnb2lzIFJldm9s?= <revol@free.fr>, qemu-devel@nongnu.org

Am 12.05.2010 20:25, schrieb Stefan Weil:
> The fix is based on a patch from Kevin Wolf. Here his comment:
>=20
> "The number of blocks needs to be rounded up to cover all of the virtua=
l hard
> disk. Without this fix, we can't even open our own images if their size=
 is not
> a multiple of the block size."
>=20
> While Kevin's patch addressed vdi_create, my modification also fixes
> vdi_open which now accepts images with odd disk sizes.
>=20
> v3:
> Don't allow reading of disk images with too large disk sizes.
> Neither VBoxManage nor old versions of qemu-img read such images.
> This change requires rounding of odd disk sizes before we do the checks.
>=20
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Fran=C3=A7ois Revol <revol@free.fr>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Thanks, applied to the block branch.

Kevin