From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35589 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCP8v-0002Ou-Um for qemu-devel@nongnu.org; Wed, 12 May 2010 23:31:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCKIu-0001AM-8a for qemu-devel@nongnu.org; Wed, 12 May 2010 18:21:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20834) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCKIu-0001A2-0B for qemu-devel@nongnu.org; Wed, 12 May 2010 18:21:24 -0400 Message-ID: <4BEB11DD.20601@redhat.com> Date: Wed, 12 May 2010 22:38:53 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1273696161-14332-1-git-send-email-crobinso@redhat.com> In-Reply-To: <1273696161-14332-1-git-send-email-crobinso@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: aliguori@us.ibm.com, clalance@redhat.com, qemu-devel@nongnu.org On 05/12/10 22:29, Cole Robinson wrote: > Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version > string from: > > QEMU PC Emulator version x.yy.z > > to > > QEMU Emulator version x.yy.z > > libvirt is overly sensitive to the format of this string, and barfs when > trying to parse qemu -help output. While libvirt should certainly be more > robust here, changing the output format of -version for cosmetic reasons > doesn't seem like the best idea, so let's revert the change and add a > comment explaining the issue. Rather than this, I would prefer a -version argument that just returns the current QEMU version string. IMHO it's not a good approach to do static string matching. Cheers, Jes