From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCTOY-0000e7-9W for qemu-devel@nongnu.org; Thu, 13 May 2010 04:03:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCTOP-00070v-0n for qemu-devel@nongnu.org; Thu, 13 May 2010 04:03:44 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:53918) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCTOO-00070V-MD for qemu-devel@nongnu.org; Thu, 13 May 2010 04:03:40 -0400 Message-ID: <4BEBAC83.6000209@web.de> Date: Thu, 13 May 2010 09:38:43 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <201004222338.06194.michael@walle.cc> <201005072257.57198.michael@walle.cc> <4BEA5F2F.8090107@web.de> <201005130102.23124.michael@walle.cc> In-Reply-To: <201005130102.23124.michael@walle.cc> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB75850CC481E96441BF2C206" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Walle Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB75850CC481E96441BF2C206 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Walle wrote: > Am Wednesday 12 May 2010 09:56:31 schrieb Jan Kiszka: >> OK, that was a hard nut. After various dead ends, I think I found an >> possible solution. Can you give this a try? > [..] >> Still requires proper patch split up, and I need to think about possib= le >> side effects. > Thanks, the patch is working. Unfortunately, now that resetting the mode on read is fixed, my whole optimization does not work any, writing to flash takes decades again. Back to the drawing board... >=20 > But i noticed another minor bug. The cfi02 doesn't handle 'read flash i= d' on=20 > 16bit accesses correctly. It always returns 8 bit. I used something lik= e >=20 > if (width =3D=3D 2) > ret =3D pfl->ident[0] << 8 | pfl->ident[1]; /* rsp. ident[1]/ident= [2] */ >=20 > within the 0x90 reading as a quick workaround. Are you sure that this is valid? The whole cfi_table is also only provided byte-wise, same in cfi01. Jan --------------enigB75850CC481E96441BF2C206 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvrrIYACgkQitSsb3rl5xSM0wCgsK3Ls57opaEd88N2DtKgOzuH 05oAn1Nn56MuhK/ULoFQ/j0FXd7VjvfW =kPwG -----END PGP SIGNATURE----- --------------enigB75850CC481E96441BF2C206--