From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: aliguori@us.ibm.com, clalance@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'
Date: Thu, 13 May 2010 10:35:14 +0200 [thread overview]
Message-ID: <4BEBB9C2.3050302@redhat.com> (raw)
In-Reply-To: <4BEB142F.2000002@redhat.com>
On 05/12/10 22:48, Cole Robinson wrote:
> I agree libvirt's method is a crappy approach. Adding a proper -version
> argument is certainly the way forward, but doesn't help users with
> existing libvirt installations that want to use latest qemu. This is the
> type of issue that libvirt devs will be fielding for months. Ideally i'd
> like the order to be:
>
> 1) Apply this patch
> 2) Add a proper -version argument, maybe named -version_num
> 3) libvirt patched to use new version argument (and robustify legacy
> version parsing)
> 4) Some reasonable amount of time from now (6 months, a year?), edit the
> current -version string at will
>
> I'd be willing to do 2 and 3 if people agree.
Hi Cole,
I think rather than 1, it would be better to add a patch to libvirt to
catch both formats. I know Chris Lalancette already cooked up a patch
for this. Combined with the 2) patch I just posted, and 3) I think that
should take care of the problems.
Cheers,
Jes
next prev parent reply other threads:[~2010-05-13 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 20:29 [Qemu-devel] [PATCH] Revive -version 'QEMU PC Emulator...' Cole Robinson
2010-05-12 20:38 ` [Qemu-devel] " Jes Sorensen
2010-05-12 20:48 ` Cole Robinson
2010-05-13 8:35 ` Jes Sorensen [this message]
2010-05-13 13:04 ` Cole Robinson
2010-05-13 13:07 ` Jes Sorensen
2010-05-13 13:21 ` Daniel P. Berrange
2010-05-13 13:38 ` Luiz Capitulino
2010-05-13 14:00 ` Paul Brook
2010-05-13 19:20 ` Blue Swirl
2010-05-13 21:24 ` Stuart Brady
2010-05-14 13:24 ` Anthony Liguori
2010-05-14 13:54 ` Daniel P. Berrange
2010-05-14 14:22 ` Anthony Liguori
2010-05-14 14:42 ` Daniel P. Berrange
2010-05-14 14:52 ` Anthony Liguori
2010-05-14 15:02 ` Daniel P. Berrange
2010-05-14 15:08 ` Anthony Liguori
2010-05-14 13:17 ` Anthony Liguori
2010-05-14 13:25 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEBB9C2.3050302@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=clalance@redhat.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).