From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45036 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCWs4-0007Qk-65 for qemu-devel@nongnu.org; Thu, 13 May 2010 07:46:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCWs2-0005r5-EJ for qemu-devel@nongnu.org; Thu, 13 May 2010 07:46:32 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:58893) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCWs2-0005qr-2O for qemu-devel@nongnu.org; Thu, 13 May 2010 07:46:30 -0400 Message-ID: <4BEBE688.5060204@web.de> Date: Thu, 13 May 2010 13:46:16 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <201004222338.06194.michael@walle.cc> <201005130102.23124.michael@walle.cc> <4BEBAC83.6000209@web.de> <201005131258.28613.michael@walle.cc> In-Reply-To: <201005131258.28613.michael@walle.cc> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB54033CD20AB2A1B15481D60" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Walle Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB54033CD20AB2A1B15481D60 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Walle wrote: > Am Thursday 13 May 2010 09:38:43 schrieb Jan Kiszka: >>> But i noticed another minor bug. The cfi02 doesn't handle 'read flash= id' >>> on 16bit accesses correctly. It always returns 8 bit. I used somethin= g >>> like >>> >>> if (width =3D=3D 2) >>> ret =3D pfl->ident[0] << 8 | pfl->ident[1]; /* rsp. ident[1]/ide= nt[2] >>> */ >>> >>> within the 0x90 reading as a quick workaround. >> Are you sure that this is valid? The whole cfi_table is also only >> provided byte-wise, same in cfi01. >=20 > At least the JEDEC ID read returns 16 bit values with x16 devices. Have= a look=20 > at: > http://www.spansion.com/Support/Datasheets/s29gl128_256n_sp_a2_e.pdf > Table II on page 51 >=20 > micromonitor (the program i tested with) and uboot uses 16bit reads to = read=20 > the flash id. Have a look at > http://git.denx.de/cgi-bin/gitweb.cgi?p=3Du-boot.git;a=3Dblob;f=3Ddrive= rs/mtd/cfi_flash.c;h=3D3267c5de36d1b12a190f93f9a3048ded598f84aa;hb=3DHEAD= #l1535 >=20 Right, I came to the same conclusion based on chip I'm using for the Musicpal model. Working on a proper fix - now that I think to have found a solution for the XIP vs. mode switch conflict. Jan --------------enigB54033CD20AB2A1B15481D60 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkvr5pMACgkQitSsb3rl5xRpWwCdE8SB4ru62GQukExzRyqB4jt/ 5GUAnRVrBnc2eWsh2uEyox5OnC7o0zWG =3rza -----END PGP SIGNATURE----- --------------enigB54033CD20AB2A1B15481D60--