* [Qemu-devel] [PATCH] musicpal: Drop redundant reset call
@ 2010-05-13 13:09 Jan Kiszka
2010-05-28 19:49 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-05-13 13:09 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
Reset is now triggered after init, no need for explicit calls anymore.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/musicpal.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/musicpal.c b/hw/musicpal.c
index ebd933e..d44c5a0 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
musicpal_gpio_writefn, s);
sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
- musicpal_gpio_reset(&dev->qdev);
-
qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
--
1.6.0.2
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call
2010-05-13 13:09 [Qemu-devel] [PATCH] musicpal: Drop redundant reset call Jan Kiszka
@ 2010-05-28 19:49 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-05-28 19:49 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote:
> Reset is now triggered after init, no need for explicit calls anymore.
Thanks, applied.
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/musicpal.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index ebd933e..d44c5a0 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
> musicpal_gpio_writefn, s);
> sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
>
> - musicpal_gpio_reset(&dev->qdev);
> -
> qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
>
> qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
> --
> 1.6.0.2
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-28 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-13 13:09 [Qemu-devel] [PATCH] musicpal: Drop redundant reset call Jan Kiszka
2010-05-28 19:49 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).