From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50151 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCbBx-0003Ph-J1 for qemu-devel@nongnu.org; Thu, 13 May 2010 12:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCbBu-0001M3-H7 for qemu-devel@nongnu.org; Thu, 13 May 2010 12:23:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47420) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCbBu-0001Ls-9t for qemu-devel@nongnu.org; Thu, 13 May 2010 12:23:18 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4DGNGKd001078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 May 2010 12:23:17 -0400 Message-ID: <4BEC276F.1020103@redhat.com> Date: Thu, 13 May 2010 19:23:11 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com> <1273086712-29163-2-git-send-email-lcapitulino@redhat.com> <4BEC031D.6020506@redhat.com> <20100513115524.29f826a0@redhat.com> <20100513150136.GL12207@redhat.com> In-Reply-To: <20100513150136.GL12207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, bazulay@redhat.com, juzhang@redhat.com, armbru@redhat.com, Luiz Capitulino On 05/13/2010 06:01 PM, Daniel P. Berrange wrote: > >> Yes, we do and it's used by libvirt iirc. >> > This command has been in QEMU for quite a long time now (0.9.x IIRC). > It wasn't in QMP until 0.12. We shouldn't have put it there in that form. > IIRC, Gerd's SPICE proposal should include a brand new QMP command for > setting both VNC and SPICE authentication information, since it has > more than just a single password arg. At that point this use of change > for VNC could be deprecated > Yes. Yet management tools who want to support 0.12 will need to support the awkward multiplexor as well. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.