From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37459 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCbkv-0003O4-0g
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:59:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OCbkt-00075L-GF
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:59:28 -0400
Received: from are.twiddle.net ([75.149.56.221]:36240)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1OCbkt-000753-B0
	for qemu-devel@nongnu.org; Thu, 13 May 2010 12:59:27 -0400
Message-ID: <4BEC2FEC.6070900@twiddle.net>
Date: Thu, 13 May 2010 09:59:24 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536
	when /proc/sys/vm/mmap_min_addr cannot be read
References: <1273756645-11149-1-git-send-email-Martin.Jansa@gmail.com>
In-Reply-To: <1273756645-11149-1-git-send-email-Martin.Jansa@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: qemu-devel@nongnu.org

On 05/13/2010 06:17 AM, Martin Jansa wrote:
> @@ -2899,8 +2900,14 @@ int main(int argc, char **argv, char **envp)
>              if (fscanf(fp, "%lu", &tmp) == 1) {
>                  mmap_min_addr = tmp;
>                  qemu_log("host mmap_min_addr=0x%lx\n", mmap_min_addr);
> +            } else {
> +                qemu_log("cannot read value from /proc/sys/vm/mmap_min_addr, assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> +                mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
>              }
>              fclose(fp);
> +        } else {
> +            qemu_log("cannot open /proc/sys/vm/mmap_min_addr for reading, assuming %d\n", MMAP_MIN_ADDR_DEFAULT);
> +            mmap_min_addr = MMAP_MIN_ADDR_DEFAULT;
>          }
>      }

Perhaps you can combine these two else clauses?


r~