From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44298 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCumC-0002Fi-3A for qemu-devel@nongnu.org; Fri, 14 May 2010 09:18:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCumA-0001kr-64 for qemu-devel@nongnu.org; Fri, 14 May 2010 09:18:04 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:38048) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCumA-0001k0-33 for qemu-devel@nongnu.org; Fri, 14 May 2010 09:18:02 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e5.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4ED1r4h010275 for ; Fri, 14 May 2010 09:01:53 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4EDHqUb116100 for ; Fri, 14 May 2010 09:17:52 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4EDHpZB000805 for ; Fri, 14 May 2010 09:17:51 -0400 Message-ID: <4BED4D7E.50606@linux.vnet.ibm.com> Date: Fri, 14 May 2010 08:17:50 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1273696161-14332-1-git-send-email-crobinso@redhat.com> <4BEB11DD.20601@redhat.com> <4BEB142F.2000002@redhat.com> In-Reply-To: <4BEB142F.2000002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: Jes Sorensen , Anthony Liguori , clalance@redhat.com, qemu-devel@nongnu.org On 05/12/2010 03:48 PM, Cole Robinson wrote: > On 05/12/2010 04:38 PM, Jes Sorensen wrote: > >> On 05/12/10 22:29, Cole Robinson wrote: >> >>> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version >>> string from: >>> >>> QEMU PC Emulator version x.yy.z >>> >>> to >>> >>> QEMU Emulator version x.yy.z >>> >>> libvirt is overly sensitive to the format of this string, and barfs when >>> trying to parse qemu -help output. While libvirt should certainly be more >>> robust here, changing the output format of -version for cosmetic reasons >>> doesn't seem like the best idea, so let's revert the change and add a >>> comment explaining the issue. >>> >> Rather than this, I would prefer a -version argument that just returns >> the current QEMU version string. >> >> IMHO it's not a good approach to do static string matching. >> >> > I agree libvirt's method is a crappy approach. Adding a proper -version > argument is certainly the way forward, but doesn't help users with > existing libvirt installations that want to use latest qemu. This is the > type of issue that libvirt devs will be fielding for months. Ideally i'd > like the order to be: > > 1) Apply this patch > 2) Add a proper -version argument, maybe named -version_num > 3) libvirt patched to use new version argument (and robustify legacy > version parsing) > 4) Some reasonable amount of time from now (6 months, a year?), edit the > current -version string at will > > I'd be willing to do 2 and 3 if people agree. > I'd like to see exactly what information libvirt needs so that we can agree on the proper interface to obtain it. My concern is that we'd have the same problem with the version string. This topic has come up many times in the past. We don't support the format of help output and libvirt shouldn't be using it. That's been expressed many, many times in the past and libvirt has not stopped using it. I think applying this patch is okay but only as part of a larger series that fixes the problem properly. Regards, Anthony Liguori > Thanks, > Cole > >