From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40918 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCusS-00062g-6k for qemu-devel@nongnu.org; Fri, 14 May 2010 09:24:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCusQ-0002aR-EL for qemu-devel@nongnu.org; Fri, 14 May 2010 09:24:31 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:45919) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCusQ-0002aJ-7w for qemu-devel@nongnu.org; Fri, 14 May 2010 09:24:30 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4EDI4Rg023239 for ; Fri, 14 May 2010 07:18:04 -0600 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4EDOHnv011706 for ; Fri, 14 May 2010 07:24:20 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4E6ODsW002782 for ; Fri, 14 May 2010 00:24:13 -0600 Message-ID: <4BED4EF9.3090800@linux.vnet.ibm.com> Date: Fri, 14 May 2010 08:24:09 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1273696161-14332-1-git-send-email-crobinso@redhat.com> <4BEB11DD.20601@redhat.com> <4BEB142F.2000002@redhat.com> <4BEBB9C2.3050302@redhat.com> <4BEBF8D1.7060401@redhat.com> <4BEBF9A5.3070507@redhat.com> In-Reply-To: <4BEBF9A5.3070507@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Anthony Liguori , clalance@redhat.com, qemu-devel@nongnu.org, Cole Robinson On 05/13/2010 08:07 AM, Jes Sorensen wrote: > On 05/13/10 15:04, Cole Robinson wrote: > >> On 05/13/2010 04:35 AM, Jes Sorensen wrote: >> >>> On 05/12/10 22:48, Cole Robinson wrote: >>> I think rather than 1, it would be better to add a patch to libvirt to >>> catch both formats. I know Chris Lalancette already cooked up a patch >>> for this. Combined with the 2) patch I just posted, and 3) I think that >>> should take care of the problems. >>> >> It doesn't solve the problem for existing libvirt installations. It's >> not uncommon for users to track just the latest kvm releases without >> upgrading libvirt: any future qemu or kvm release will break every >> version of libvirt that exists today. Given that unfortunate case, I >> still recommend reverting the 'PC' change at least for long enough for a >> few fixed libvirt releases to make it into the wild. >> > But that is no different from what we have today. Users who update their > qemu and see issues with libvirt can also be asked to update libvirt. I > have already had several cases where I needed to do that anyway. > > I don't like reverting a change like this, just to schedule it to be > reapplied again later. > The problem is, we've been down this road many times before. Every time, the libvirt folks say they just need this one change for compatibility and keep on using the help output. I understand that that's the easiest thing to do so we need to make it easier for them to do the right thing (which probably means making it harder to do the wrong thing :-)). So I'm willing to apply this patch but only as part of a larger series that eliminates the need for libvirt to parse help output. The important question is then, what information is libvirt getting from the help output today. Regards, Anthony Liguori > Cheers, > Jes > >