From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: miguel.filho@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: [RFC] New Monitor command: 'info netdevices'
Date: Fri, 14 May 2010 08:30:19 -0500 [thread overview]
Message-ID: <4BED506B.9010403@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100513111809.551fdb12@redhat.com>
On 05/13/2010 09:18 AM, Luiz Capitulino wrote:
> Hi there,
>
> Miguel is working on converting 'info network' to QMP, but turns out that it's
> been quite difficult to maintain the exact same output.
>
> The main problem seems to be the usage of the 'info_str' string, which some
> drivers (like tap, xen, vde, socket, etc) write arbitrary data into it. Then,
> it's difficult to maintain the same output when we store the same data in
> a qdict.
>
> Another problem is wrt to maintaining the same ordering of devices, while
> there's a solution for this one, the code gets ugly.
>
> We have to choices:
>
> 1. Convert it, anyway. Try our best not to break the output, even knowing
> this is likely to happen
>
> 2. Play it safe and introduce a new 'info netdevices' command, which
> just print one device per line
>
> I think 2 is better.
>
> PS: As far as I know, 'info network' is not used by libvirt.
>
I'd vote for (2).
Regards,
Anthony Liguori
prev parent reply other threads:[~2010-05-14 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 14:18 [Qemu-devel] [RFC] New Monitor command: 'info netdevices' Luiz Capitulino
2010-05-14 9:46 ` Markus Armbruster
2010-05-14 12:38 ` Miguel Di Ciurcio Filho
2010-05-14 14:07 ` Luiz Capitulino
2010-05-14 13:30 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED506B.9010403@linux.vnet.ibm.com \
--to=aliguori@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).