From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55547 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OCuy9-0001oq-3Z for qemu-devel@nongnu.org; Fri, 14 May 2010 09:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OCuy7-0003Rr-EW for qemu-devel@nongnu.org; Fri, 14 May 2010 09:30:24 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:38928) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCuy7-0003Rj-By for qemu-devel@nongnu.org; Fri, 14 May 2010 09:30:23 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e6.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o4EDSOjc016353 for ; Fri, 14 May 2010 09:28:24 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o4EDUL1K152872 for ; Fri, 14 May 2010 09:30:21 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o4EDUKLW027516 for ; Fri, 14 May 2010 09:30:21 -0400 Message-ID: <4BED506B.9010403@linux.vnet.ibm.com> Date: Fri, 14 May 2010 08:30:19 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20100513111809.551fdb12@redhat.com> In-Reply-To: <20100513111809.551fdb12@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC] New Monitor command: 'info netdevices' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: miguel.filho@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com On 05/13/2010 09:18 AM, Luiz Capitulino wrote: > Hi there, > > Miguel is working on converting 'info network' to QMP, but turns out that it's > been quite difficult to maintain the exact same output. > > The main problem seems to be the usage of the 'info_str' string, which some > drivers (like tap, xen, vde, socket, etc) write arbitrary data into it. Then, > it's difficult to maintain the same output when we store the same data in > a qdict. > > Another problem is wrt to maintaining the same ordering of devices, while > there's a solution for this one, the code gets ugly. > > We have to choices: > > 1. Convert it, anyway. Try our best not to break the output, even knowing > this is likely to happen > > 2. Play it safe and introduce a new 'info netdevices' command, which > just print one device per line > > I think 2 is better. > > PS: As far as I know, 'info network' is not used by libvirt. > I'd vote for (2). Regards, Anthony Liguori