From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37709 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCx2b-00078k-CV
	for qemu-devel@nongnu.org; Fri, 14 May 2010 11:43:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCx2Z-0005LY-Jx
	for qemu-devel@nongnu.org; Fri, 14 May 2010 11:43:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22807)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCx2Z-0005Kz-BB
	for qemu-devel@nongnu.org; Fri, 14 May 2010 11:43:07 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EFh5rM014486
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 May 2010 11:43:05 -0400
Message-ID: <4BED6F85.50309@redhat.com>
Date: Fri, 14 May 2010 18:43:01 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com>	<1273086712-29163-2-git-send-email-lcapitulino@redhat.com>	<4BEC031D.6020506@redhat.com>
	<m3pr0yq333.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3pr0yq333.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: bazulay@redhat.com, juzhang@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 05/14/2010 11:50 AM, Markus Armbruster wrote:
>
>>> +
>>> +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
>>>
>>>        
>> Oh, we do have more.
>>
>> Please document the units for this value (bits per second)?
>>      
> bytes per second?
>    

Bandwidth is typically measured in bits per second.

>>> +- "bus": identical to the parent's bus number (json-int)
>>> +- "slot": slot number (json-int)
>>> +- "function": function number (json-int)
>>>
>>>        
>> Would have been nicer as a nested object (list of buses, each
>> containing a list of slots, each containing a list of functions).
>>      
> We have a list of buses, each containing a list of device functions.
> Not sure the additional level of nesting you propose buys us anything.
>    

A slot is the hotpluggable entity.  Open your computer and you can 
actually see them.

btw would be good to list empty slots as well.

What about PCI domains?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.