From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50180 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCxxy-0004Xn-Aj
	for qemu-devel@nongnu.org; Fri, 14 May 2010 12:42:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCxxw-0005En-8R
	for qemu-devel@nongnu.org; Fri, 14 May 2010 12:42:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63742)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCxxw-0005EV-19
	for qemu-devel@nongnu.org; Fri, 14 May 2010 12:42:24 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EGgNBj024391
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 May 2010 12:42:23 -0400
Message-ID: <4BED7D6C.4010205@redhat.com>
Date: Fri, 14 May 2010 19:42:20 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com>	<1273086712-29163-2-git-send-email-lcapitulino@redhat.com>	<4BEC031D.6020506@redhat.com>
	<20100513115524.29f826a0@redhat.com>	<20100513150136.GL12207@redhat.com>
	<4BEC276F.1020103@redhat.com>	<20100513185748.7bcaf32c@redhat.com>
	<m3bpcirify.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3bpcirify.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: bazulay@redhat.com, juzhang@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 05/14/2010 11:33 AM, Markus Armbruster wrote:
>
> And we absolutely need to make use of that license to improve stuff.
> Premature stability leads to stable crap.  Having to get everything
> right the first time is just too hard for mortals.
>    

If that is the way we go (and I'm not sure what's the right thing here) 
then I suggest the following strategy:

- fix the patch so it describes the current state of things accurately
- merge
- post patches that change both the code and the documentation to fix 
protocol problems

That is, separate bugs in the documentation from bugs in the protocol; 
that allows new commands to be implemented and documented in parallel 
with fixing the old commands.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.