From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40854 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCyO4-0007Lv-H6
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:09:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCyO2-000180-5A
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:09:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63230)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1OCyO1-00017u-S8
	for qemu-devel@nongnu.org; Fri, 14 May 2010 13:09:22 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4EH9Lwm030766
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 14 May 2010 13:09:21 -0400
Message-ID: <4BED83BD.8000604@redhat.com>
Date: Fri, 14 May 2010 20:09:17 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc
References: <1273086712-29163-1-git-send-email-lcapitulino@redhat.com>	<1273086712-29163-2-git-send-email-lcapitulino@redhat.com>	<4BEC031D.6020506@redhat.com>
	<m3pr0yq333.fsf@blackfin.pond.sub.org>	<4BED6F85.50309@redhat.com>
	<m3tyqa5sbb.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3tyqa5sbb.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: bazulay@redhat.com, juzhang@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 05/14/2010 08:03 PM, Markus Armbruster wrote:
> Avi Kivity<avi@redhat.com>  writes:
>
>    
>> On 05/14/2010 11:50 AM, Markus Armbruster wrote:
>>      
>>>        
>>>>> +
>>>>> +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } }
>>>>>
>>>>>
>>>>>            
>>>> Oh, we do have more.
>>>>
>>>> Please document the units for this value (bits per second)?
>>>>
>>>>          
>>> bytes per second?
>>>
>>>        
>> Bandwidth is typically measured in bits per second.
>>      
> The question is what unit the code actually uses.  What it should use is
> separate, if valid question.
>    

Right.

>>> We have a list of buses, each containing a list of device functions.
>>> Not sure the additional level of nesting you propose buys us anything.
>>>
>>>        
>> A slot is the hotpluggable entity.  Open your computer and you can
>> actually see them.
>>      
> QEMU doesn't really know that.
>    

How can that be?  Do we signal hotplug notifications to a function or to 
a slot?

Can we hotplug a single function in an already occupied slot?

>> btw would be good to list empty slots as well.
>>      
> Why?
>    

So management knows how many slots are available.

It's the difference between:

    Error: the device could not be hotplugged

and

<button disabled="yes">Hotplug device</button>

   or

   3 PCI slots free.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.