* [Qemu-devel] [PATCH] Put dependency files in proper subdir
@ 2010-05-15 11:03 Jan Kiszka
2010-05-15 11:13 ` [Qemu-devel] " Jan Kiszka
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jan Kiszka @ 2010-05-15 11:03 UTC (permalink / raw)
To: qemu-devel, Juan Quintela
From: Jan Kiszka <jan.kiszka@siemens.com>
This seems to resolve subtle breakages of our build system:
Dependency files generated for targets like 'dir/foo.o' were saved as
'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
file was overwritten. Concrete example: libhw*/macio.o vs.
libhw*/ide/macio.o. And this often left a segfaulting build result
behind when changing the "wrong" data structures".
Fix it by generating proper 'dir/foo.d'.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
rules.mak | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rules.mak b/rules.mak
index 7e10432..c843a13 100644
--- a/rules.mak
+++ b/rules.mak
@@ -12,7 +12,7 @@ MAKEFLAGS += -rR
%.mak:
# Flags for dependency generation
-QEMU_DGFLAGS += -MMD -MP -MT $@
+QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
%.o: %.c
$(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
-o $@ $<," CC $(TARGET_DIR)$@")
--
1.6.0.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir
2010-05-15 11:03 [Qemu-devel] [PATCH] Put dependency files in proper subdir Jan Kiszka
@ 2010-05-15 11:13 ` Jan Kiszka
2010-05-16 9:41 ` Paolo Bonzini
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jan Kiszka @ 2010-05-15 11:13 UTC (permalink / raw)
To: qemu-devel, Juan Quintela
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This seems to resolve subtle breakages of our build system:
>
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".
Actually, most lethal was qdev.o vs. ide/qdev.o.
Jan
>
> Fix it by generating proper 'dir/foo.d'.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> rules.mak | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 7e10432..c843a13 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -12,7 +12,7 @@ MAKEFLAGS += -rR
> %.mak:
>
> # Flags for dependency generation
> -QEMU_DGFLAGS += -MMD -MP -MT $@
> +QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>
> %.o: %.c
> $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
> -o $@ $<," CC $(TARGET_DIR)$@")
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir
2010-05-15 11:03 [Qemu-devel] [PATCH] Put dependency files in proper subdir Jan Kiszka
2010-05-15 11:13 ` [Qemu-devel] " Jan Kiszka
@ 2010-05-16 9:41 ` Paolo Bonzini
2010-05-16 9:49 ` Juan Quintela
2010-05-22 9:27 ` [Qemu-devel] " Blue Swirl
3 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2010-05-16 9:41 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Juan Quintela
On 05/15/2010 01:03 PM, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> This seems to resolve subtle breakages of our build system:
>
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".
>
> Fix it by generating proper 'dir/foo.d'.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir
2010-05-15 11:03 [Qemu-devel] [PATCH] Put dependency files in proper subdir Jan Kiszka
2010-05-15 11:13 ` [Qemu-devel] " Jan Kiszka
2010-05-16 9:41 ` Paolo Bonzini
@ 2010-05-16 9:49 ` Juan Quintela
2010-05-22 9:27 ` [Qemu-devel] " Blue Swirl
3 siblings, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2010-05-16 9:49 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
Jan Kiszka <jan.kiszka@web.de> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This seems to resolve subtle breakages of our build system:
>
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".
>
> Fix it by generating proper 'dir/foo.d'.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Put dependency files in proper subdir
2010-05-15 11:03 [Qemu-devel] [PATCH] Put dependency files in proper subdir Jan Kiszka
` (2 preceding siblings ...)
2010-05-16 9:49 ` Juan Quintela
@ 2010-05-22 9:27 ` Blue Swirl
3 siblings, 0 replies; 5+ messages in thread
From: Blue Swirl @ 2010-05-22 9:27 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, Juan Quintela
Thanks, applied.
On Sat, May 15, 2010 at 11:03 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This seems to resolve subtle breakages of our build system:
>
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency
> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".
>
> Fix it by generating proper 'dir/foo.d'.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> rules.mak | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 7e10432..c843a13 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -12,7 +12,7 @@ MAKEFLAGS += -rR
> %.mak:
>
> # Flags for dependency generation
> -QEMU_DGFLAGS += -MMD -MP -MT $@
> +QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>
> %.o: %.c
> $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c
> -o $@ $<," CC $(TARGET_DIR)$@")
> --
> 1.6.0.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-22 9:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-15 11:03 [Qemu-devel] [PATCH] Put dependency files in proper subdir Jan Kiszka
2010-05-15 11:13 ` [Qemu-devel] " Jan Kiszka
2010-05-16 9:41 ` Paolo Bonzini
2010-05-16 9:49 ` Juan Quintela
2010-05-22 9:27 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).