From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40944 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODFJX-0006jA-7a
	for qemu-devel@nongnu.org; Sat, 15 May 2010 07:13:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODFJV-0001q6-7m
	for qemu-devel@nongnu.org; Sat, 15 May 2010 07:13:51 -0400
Received: from fmmailgate03.web.de ([217.72.192.234]:53945)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODFJU-0001pv-T4
	for qemu-devel@nongnu.org; Sat, 15 May 2010 07:13:49 -0400
Message-ID: <4BEE81E3.2030209@web.de>
Date: Sat, 15 May 2010 13:13:39 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4BEE7F80.2090203@web.de>
In-Reply-To: <4BEE7F80.2090203@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig532482FA41E686F6C2095ED5"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] Put dependency files in proper subdir
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig532482FA41E686F6C2095ED5
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> This seems to resolve subtle breakages of our build system:
>=20
> Dependency files generated for targets like 'dir/foo.o' were saved as
> 'foo.d'. Now, if there was also a target 'foo.o', one of the dependency=

> file was overwritten. Concrete example: libhw*/macio.o vs.
> libhw*/ide/macio.o. And this often left a segfaulting build result
> behind when changing the "wrong" data structures".

Actually, most lethal was qdev.o vs. ide/qdev.o.

Jan

>=20
> Fix it by generating proper 'dir/foo.d'.
>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  rules.mak |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/rules.mak b/rules.mak
> index 7e10432..c843a13 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -12,7 +12,7 @@ MAKEFLAGS +=3D -rR
>  %.mak:
>=20
>  # Flags for dependency generation
> -QEMU_DGFLAGS +=3D -MMD -MP -MT $@
> +QEMU_DGFLAGS +=3D -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>=20
>  %.o: %.c
>  	$(call quiet-command,$(CC) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -=
c
> -o $@ $<,"  CC    $(TARGET_DIR)$@")



--------------enig532482FA41E686F6C2095ED5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkvugekACgkQitSsb3rl5xRnKgCgoueJ41oEsQPcV8tn2pz1lMt8
KKUAnixtj9VzB7JtrvtnK2AhKccVQaU3
=QIaS
-----END PGP SIGNATURE-----

--------------enig532482FA41E686F6C2095ED5--