From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56711 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ODHJw-00051Q-AJ
	for qemu-devel@nongnu.org; Sat, 15 May 2010 09:22:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODHJu-0000Ah-Bi
	for qemu-devel@nongnu.org; Sat, 15 May 2010 09:22:24 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:49331)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jan.kiszka@web.de>) id 1ODHJu-0000AH-0E
	for qemu-devel@nongnu.org; Sat, 15 May 2010 09:22:22 -0400
Message-ID: <4BEEA006.1030308@web.de>
Date: Sat, 15 May 2010 15:22:14 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <cover.1273923157.git.jan.kiszka@web.de>	
	<caddc227d2b976be4267fccc2d82f4b87c62fc76.1273923157.git.jan.kiszka@web.de>
	<AANLkTimzP6nK5qpkxkEJSKo-i0p8f674C_3uYUuE3dBn@mail.gmail.com>
In-Reply-To: <AANLkTimzP6nK5qpkxkEJSKo-i0p8f674C_3uYUuE3dBn@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigFE641BF9A5017F9BC388F999"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigFE641BF9A5017F9BC388F999
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

andrzej zaborowski wrote:
> Hi Jan,
>=20
> On 15 May 2010 13:32, Jan Kiszka <jan.kiszka@web.de> wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> It was only written, but never read.
>=20
> I pushed an alternate version to just move the update from post_save
> to post_load.  If you think of code as documentation, the struct
> becomes less complete in representing the state of the device if you
> remove the register.  State doesn't have to be readable through the
> busses, some state may be readable through qemu monitor and the like.

That particular state is unreadable via any existing interface (except a
debugger). For pretty-printing TMP105State::config, there will once be
better mechanisms based on vmstate.

I don't mind if that dead code remains, I just want to underline that
it's useless (code as documentation was important before versioning
control entered the scene).

Jan


--------------enigFE641BF9A5017F9BC388F999
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkvuoAoACgkQitSsb3rl5xR0pwCcCmX8vIM6lWFySd/wVu8NQYza
lhQAn2uCgvT5DO9MG9783sx9sqx0sEw/
=/ysy
-----END PGP SIGNATURE-----

--------------enigFE641BF9A5017F9BC388F999--